Remove unnecessary conditional from print action #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will be useful to have the "only-flush" option in the print action, for a fast first attempt to debug flush related problems. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #48 +/- ##
========================================
Coverage 22.91% 22.91%
========================================
Files 292 292
Lines 30589 30589
Branches 1169 1169
========================================
Hits 7009 7009
Misses 23580 23580 ☔ View full report in Codecov by Sentry. |
dsarmany
approved these changes
Jan 15, 2025
stefaniereuter
changed the title
Do you want this to be in this PR? I think it may make sense to have it as a separate, small feature request with the small test. that demonstrates its use. |
|
Yes I agree should be in a separate feature branch. |
|
I've changed the commit message |
dsarmany
force-pushed
the
feature/cleanup-print
branch
from
57758cf to
5b6b262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change in behavior just deleting an unnecessary conditional. msg.tag()==message::Message::Tag::Field is already either true or false and does not need to be matched with identical bools in a conditional.