-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update interpolate action to output HEALPix_nested directly #50
base: develop
Are you sure you want to change the base?
Conversation
caching: false | ||
- type: metadata-mapping | ||
mapping: '{~}/mapping_1024.yaml' | ||
- type: renumber-healpix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the renumbering option altogether, as well as associated code -- this is legacy and not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing renumber HEALPix requires a lot of modifications in climateDT. RAPS, multIO plans, and moreover there is still the FESOM interpolation (interpolation from matrix) pending question (who will remap the matrices?). My understanding is that now we are in a very busy phase and it is better to not touch for the moment.
caching: false | ||
- type: metadata-mapping | ||
mapping: '{~}/mapping_32.yaml' | ||
- type: renumber-healpix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I'd remove all cases/code refering to renumbering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent -- though I'd remove teh renumebering functionality/tests
Added a test test with reference data generated without the changes in the interpolate action. The output is exactly the same as before, even if you use the original plan. As requested by @stefaniereuter The commit from @MircoValentiniECMWF is a tool which lets you convert the matrices needed for fesom, this is work in progress. We still need to test it and possibly make a few changes. |
some more points:
|
For one of the points above, you can also modify the mir-codec-to-weight-matrix tool to renumber the input and/or output indices directly. |
I think it is okay to keep the duplicates, given that we want to get rid of the whole action anyway. I am happy to give climate DT a bit of a breathing space right now. But at some point, and still sooner rather than later, I agree with @pmaciel that we should just simply remove this action and force the climate-DT plans to be updated. |
This change removes the need to use the renumber-healpix action to interpolate to a HEALPix_nested. You can now do it in the interpolate action directly.
Draft because I think we might want to consider adding a few more things: