Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stake option to device #139

Merged
merged 2 commits into from
Jun 14, 2023
Merged

feat: add stake option to device #139

merged 2 commits into from
Jun 14, 2023

Conversation

PodTheCoder
Copy link
Contributor

Adapted code based on #138.

@PodTheCoder
Copy link
Contributor Author

Changes:

  • Fork based on develop branch.
  • The --stake option is used instead of --remote-stake. A complication: The naming stake overlapped within the node assignment function arg of src/device/index.ts. Resolved by naming the function arg stakeId.

annybs
annybs approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@annybs annybs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for acting on the change requests so quickly and cleanly. This looks OK to me. I'll merge and carry out testing this week, and it should be included in the next CLI release.

@annybs annybs self-assigned this Jun 14, 2023
@annybs annybs merged commit 234735f into edge:develop Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annybs annybs annybs approved these changes

Assignees

@annybs annybs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PodTheCoder @annybs