Refactor Dockerfile.dev to declare TARGETPLATFORM without a default v…

…alue for improved multi-arch support
eduardolat · Nov 2, 2024 · 5f60984 · 5f60984
1 parent cf83ac2
commit 5f60984
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/docker/Dockerfile b/docker/Dockerfile
@@ -1,13 +1,12 @@
 # Declare the target platform to support multi-arch builds
-ARG TARGETPLATFORM=linux/amd64
+ARG TARGETPLATFORM
 
 # To make sure we have the node, and golang binaries
 FROM node:20.17.0-bookworm AS node
 FROM golang:1.23.1-bookworm AS golang
 
 # Set the base image, general environment variables, and move to temp dir
 FROM debian:12.7
-ARG TARGETPLATFORM
 RUN echo "Building for ${TARGETPLATFORM}"
 ENV DEBIAN_FRONTEND="noninteractive"
 ENV GOBIN="/usr/local/go-bin"

diff --git a/docker/Dockerfile.cicd b/docker/Dockerfile.cicd
@@ -1,13 +1,12 @@
 # Declare the target platform to support multi-arch builds
-ARG TARGETPLATFORM=linux/amd64
+ARG TARGETPLATFORM
 
 # To make sure we have the node, and golang binaries
 FROM node:20.17.0-bookworm AS node
 FROM golang:1.23.1-bookworm AS golang
 
 # Set the base image, general environment variables, and move to temp dir
 FROM debian:12.7
-ARG TARGETPLATFORM
 RUN echo "Building for ${TARGETPLATFORM}"
 ENV DEBIAN_FRONTEND="noninteractive"
 ENV GOBIN="/usr/local/go-bin"

diff --git a/docker/Dockerfile.dev b/docker/Dockerfile.dev
@@ -1,13 +1,12 @@
 # Declare the target platform to support multi-arch builds
-ARG TARGETPLATFORM=linux/amd64
+ARG TARGETPLATFORM
 
 # To make sure we have the node, and golang binaries
 FROM node:20.17.0-bookworm AS node
 FROM golang:1.23.1-bookworm AS golang
 
 # Set the base image, general environment variables, and move to temp dir
 FROM debian:12.7
-ARG TARGETPLATFORM
 RUN echo "Building for ${TARGETPLATFORM}"
 ENV DEBIAN_FRONTEND="noninteractive"
 ENV GOBIN="/usr/local/go-bin"