Added password encryption for ZIP files #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh great, exactly what I was looking for. Can we get this merged? :) |
|
The only thing missing for me and what is preventing me from using pgbackweb right now. Awesome if we can get this merged! |
|
Let me modify it so that the passwords are set at the backup level instead of globally, this way it is much more flexible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added password encryption for ZIP files used both in local and remote (S3/Minio) destinations.
Working with remote destinations it's often the case the bucket is shared across different teams/projects or permissions are not fine-grained. So, in order to prevent data leaks, and as best practice when uploading data to third party services encrypting files is a way to go.
This PR adds support for encrypting dump and decrypting upon restoration - by replacing
unziputility withp7zip.