Handle track ended properly

edumeet · Mar 12, 2024 · d7f5c56 · d7f5c56
1 parent c64061a
commit d7f5c56
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/utils/mediaSender.tsx b/src/utils/mediaSender.tsx
@@ -111,20 +111,20 @@ export class MediaSender extends EventEmitter {
 		this.maybeAddHark();
 	}
 
-	public stop(local = true): void {
+	public stop(local = true, notifyServer = false): void {
 		logger.debug('stop() [local:%s, source:%s]', local, this.source);
 
 		if (!this.running) return;
 
 		this.running = false;
 
 		if (this.producer) {
-			this.producer.appData.remoteClosed = !local;
+			this.producer.appData.remoteClosed = !local && !notifyServer;
 			this.producer.close();
 		}
 
 		for (const producer of this.peerProducers.values()) {
-			producer.appData.remoteClosed = !local;
+			producer.appData.remoteClosed = !local && !notifyServer;
 			producer.close();
 		}
 
@@ -320,7 +320,6 @@ export class MediaSender extends EventEmitter {
 
 		producer.observer.on('pause', pauseListener);
 		producer.observer.on('resume', resumeListener);
-		producer.once('trackended', () => producer.close());
 
 		return producer;
 	}
@@ -368,7 +367,6 @@ export class MediaSender extends EventEmitter {
 
 				producer.observer.on('pause', pauseListener);
 				producer.observer.on('resume', resumeListener);
-				producer.once('trackended', () => producer.close());
 
 				this.peerProducingPromises.delete(peerId);
 
@@ -383,7 +381,7 @@ export class MediaSender extends EventEmitter {
 
 	private handleTrack(): void {
 		this.track?.addEventListener('ended', () => {
-			this.stop(false);
+			this.stop(false, true);
 		}, { once: true });
 	}
 }