Emacs package manager bootstrapping nits #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs280staff/tutorials/198/. (Available until Sat Dec 14 2024.) |
jamesjuett
approved these changes
Nov 22, 2024
Contributor
jamesjuett
left a comment
jamesjuett
left a comment
There was a problem hiding this comment.
Is this ready to review/merge? I'm not an emacs user, but I'm approving in case you'd like to go ahead and merge. I took a look at the diff and I don't see anything that looks like a mistake. @amirkamil might have comments.
Contributor
Author
|
Yep, this is tested on my machine and on CAEN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was talking with a student in EECS 485 office hours about getting started with Emacs. They were using the EECS 280 tutorial I found some minor improvements.