Skip to content

Conversation

@jamesjuett
Copy link
Contributor

This PR follows https://github.com/eecs280staff/stats/pull/380. The tutorial needs to use the new name stats rather than p1-stats.

@jamesjuett jamesjuett requested a review from aarmaane January 10, 2025 16:20
@github-actions
Copy link

The spec from this PR is available at https://preview.sesh.rs/previews/eecs280staff/tutorials/199/.

(Available until Sun Feb 09 2025.)

Copy link
Contributor

@aarmaane aarmaane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through it and LGTM! Some of the screenshots with files are outdated now, but those can be changed later.

@jamesjuett
Copy link
Contributor Author

Skimmed through it and LGTM! Some of the screenshots with files are outdated now, but those can be changed later.

Thanks for pointing out those images. I've created #200 to track that. (I think we have some bigger questions to answer about maintaining the images in light of this and some other recent changes to P1, plus any potential future changes.)

@jamesjuett jamesjuett merged commit ac56854 into main Jan 10, 2025
1 check passed
@jamesjuett jamesjuett deleted the remove-p1-from-name branch January 10, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants