-
Notifications
You must be signed in to change notification settings - Fork 8
Update CAEN Linux Remote Login Service URL #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Closes #201 |
|
I'm not sure if the host key warning needs to be included, or if the way it's included is good enough... I don't think students have accessed the Linux Remote Login Service before taking 280, but I took 280 my first semester, so I wouldn't have had a chance to see it before 280. I like having a mention of the warning so as not to cause concern (and to not accidentally ingrain "just say yes to ssh warnings"). |
awdeorio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, I found one tiny spot that you might've missed:
$ ag -Q login.engin.umich.edu
docs/setup_caen.md
63: ~/.ssh/known_hosts:1: login.engin.umich.edu
That's intended, it's part of the warning students may get when using the new URL: The host public key of the old and new CAEN URLs are the same. The first time someone who has used the old URL used the new one, they will get warned that the CAEN host key is already known as the old URL under the known_hosts file. Reusing the host key is sometimes an issue, but in the case of this CAEN service, it's fine, so we want the students to accept the connection. |
|
Whoops! That's my mistake for not checking the context when I did the text-search. LGTM |
|
Because this involves a change to a live semester, I'll tag a current instructor to say whether it's OK to merge now or if we should wait. @jamesjuett @saquibrazak @sofiazxy |
nw, it happens 👍 (it's also easier for me to see because I was the one that wrote it :P) |
jamesjuett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @hardy-ethan for making this contribution!
|
I'm going to go ahead and merge, bypassing branch predictions - the Spec Preview is failing since this a fork and one of the necessary secrets isn't provided in that case. |
https://caen.engin.umich.edu/connect/linux-login-service/