"p1-" in student-facing names #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs280staff/tutorials/208/. (Available until Wed Feb 26 2025.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
p1-back top1-statsin student-facing names, following an in-person discussion with @amirkamil and @awdeorio.The only place
statsis used is in links to the project spec and starter files. This regex can be used to verify:(?<!p1-)stats(?!\w*\.[ch]pp)It finds instances of "stats" not preceded by "p1-" and not followed by the rest of a filename, e.g. ".hpp", "_tests.cpp", etc. I found 16 of them (which includes some that would be removed by #205 and #207).