-
Notifications
You must be signed in to change notification settings - Fork 8
Fix local preview #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local preview #229
Conversation
|
BTW, it might be worth noting somewhere in the docs that Ruby 3.1.x works well for local testing. I noticed that too. If you try to use the latest version of Ruby, it becomes a headache in my experience. |
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs280staff/tutorials/229/. (Available until Sun Sep 28 2025.) |
amirkamil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Import preview fixes from eecs280staff/tutorials#229
Update Ruby dependencies to fix local rendering. Update config files to match the latest primer spec docs. I used Ruby 3.1 to generate the lock file to avoid clashes with older versions present on GitHub pages.
EDIT: This PR still needs some work. GitHub pages seems to be using Ruby 3.0, which is deprecated and no longer available on macOS via Homebrew.