Tweaks in the registers module to better support the annotation of entities other than places and people #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoernT
reviewed
Dec 16, 2024
| @@ -60,7 +60,10 @@ declare function rapi:save($request as map(*)) { | |||
| let $body := $request?body/*[1] | |||
|
|
|||
| let $type := local-name($body) | |||
There was a problem hiding this comment.
are we sure $body is defined always e.g. by api.json?
There was a problem hiding this comment.
Request body is used in the definition of the corresponding REST API endpoint:
"requestBody": {
"content": {
"application/xml": {
"schema": {
"type": "string"
}
}
}
},$request?body key is empty when the route expects no body; see source code.
…ixed conventions exist
HelenaSabel
commented
Mar 13, 2025
Comment on lines
+163
to
+169
| let $numeric-ids := for $id in $all-ids return if ($id castable as xs:integer) then $id else () | ||
| let $last := if (count($all-ids)) then sort($numeric-ids)[last()] else 1 | ||
| let $next := | ||
| try { | ||
| xs:integer($last) + 1 | ||
| } catch * { | ||
| '_error' | ||
| 1 |
There was a problem hiding this comment.
These changes here are due to a case in which the register already has entries like: rp-gnd-118536109 (in which rp- is the prefix) and then we want to generate custom entries with an ID like rp-000001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that 786bdfb is only relevant in the context of eeditiones/tei-publisher-components#193