Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #477

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Cleanup #477

wants to merge 11 commits into from

Conversation

mo-hosni
Copy link
Member

Removed a lot of obsolete/unused files after the latest updates for caravel and caravan.

@mo-hosni
Copy link
Member Author

I ran make ship and make truck and there are no issues with either.
I also ran make caravel_core and make caravan_core in openlane and there is no issue.

@algofoogle
Copy link

This is huge (not working well in GitHub UI) so probably needs an offline review again. @marwaneltoukhy what do you think? Can you check it? If it's all deletes, maybe it's fine to go as-is. Note that Caravel has changed since this PR.

@mo-hosni
Copy link
Member Author

@algofoogle Yes, it is huge. But,you can check the individual commits in the PR in the UI and it will show the exact files that has been deleted, the commits are not too many.

@d-m-bailey
Copy link
Contributor

@mo-hosni Thanks for deleting the unused files.

What about keeping the openlane/* files. I know they are not used currently, but it might be a good reference for someone that wanted to implement the functionality as a hard macro.
Besides that, I think we can delete the other files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants