Skip to content

Gh actions coverage #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Gh actions coverage #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3a88ef
coverage path
egulias Dec 31, 2024
e67aa7a
Use different action
egulias Dec 31, 2024
d164dab
Polish
egulias Dec 31, 2024
c9be65c
Different strategy
egulias Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/upload-to-codacy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ jobs:
run: mkdir -p build/coverage

- name: Download clover.xml artifact
uses: actions/download-artifact@v3
uses: dawidd6/action-download-artifact@v7
with:
workflow: unit-tests
name: clover.xml
path: build/coverage

Expand Down
2 changes: 1 addition & 1 deletion src/Validation/DNSGetRecordWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public function getRecords(string $host, int $type): DNSRecords
// A workaround to fix https://bugs.php.net/bug.php?id=73149
set_error_handler(
static function (int $errorLevel, string $errorMessage): never {
throw new \RuntimeException("Unable to get DNS record for the host: $errorMessage");
throw new \RuntimeException(sprintf('Unable to get DNS record for the host: %s', $errorMessage));
}
);
try {
Expand Down