Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mater convert, wrap contents in unixfs dag #675

Open
cernicc opened this issue Jan 14, 2025 · 1 comment
Open

feat: Mater convert, wrap contents in unixfs dag #675

cernicc opened this issue Jan 14, 2025 · 1 comment
Labels
frozen PR/Issue is on hold
Milestone

Comments

@cernicc
Copy link
Member

cernicc commented Jan 14, 2025

The client retrieval system expects a car file with dag information so that it knows which blocks to request from the server. The current issue is that when the client receives a root node. It doesn't know which blocks are next in the tree to be requested.

The current convert command converts contents to a car, but it doesn't encode any dag nodes metadata. That should be changed so that the nodes that are written to car also at least contain links to other nodes.

@pete-eiger pete-eiger linked a pull request Jan 21, 2025 that will close this issue
6 tasks
@th7nder th7nder added this to the Phase 3 milestone Feb 3, 2025
@pete-eiger pete-eiger linked a pull request Feb 4, 2025 that will close this issue
7 tasks
@jmg-duarte
Copy link
Collaborator

jmg-duarte commented Feb 17, 2025

Even though this is no longer relevant for retrieval right now, I'm keeping this one open since this is a difference between mater and go-car that we can address

@th7nder th7nder added the frozen PR/Issue is on hold label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frozen PR/Issue is on hold
Projects
None yet
4 participants