-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sector indexing and data retrieval #688
Conversation
800b896
to
cdb22b3
Compare
379156b
to
cc5a9bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huuge piece of work!
I left some major questions in the comments and have another one.
How is this thing tested?
storage-provider/server/src/indexer/local_index_directory/rdb.rs
Outdated
Show resolved
Hide resolved
storage-provider/server/src/indexer/local_index_directory/rdb.rs
Outdated
Show resolved
Hide resolved
storage-provider/server/src/indexer/local_index_directory/rdb.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think there are (IMO) some small refactors to be made that make the whole PR smaller and more understandable
storage-provider/server/src/indexer/local_index_directory/rdb.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final touchups
Description
Add sector indexing on the successful prove commitment and integrates retrieval server that uses the indexing when retrieving blocks.
The #675 should be solved before this is merged. The reason is that the client doesn't know currently which blocks it should request after the root node.
Checklist