Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support multiple partitions in PoRep #752

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Feb 14, 2025

Description

Fixes #747.
When a PoRep is configured with multiple partitions (meaning many more challenges to prove) we didn't support this case.
It's still untested, as we don't have configuration with those multiple partitions.
It'll be followed-up in #751.

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@th7nder th7nder added the enhancement New feature or request label Feb 14, 2025
@th7nder th7nder added this to the Phase 3 milestone Feb 14, 2025
@th7nder th7nder self-assigned this Feb 14, 2025
@th7nder th7nder requested review from jmg-duarte, cernicc and aidan46 and removed request for jmg-duarte, cernicc and aidan46 February 14, 2025 14:46
@jmg-duarte jmg-duarte added the ready for review Review is needed label Feb 14, 2025
jmg-duarte
jmg-duarte previously approved these changes Feb 14, 2025
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@th7nder th7nder force-pushed the feat/747/porep-partitions branch from c6a494e to 8ae1f37 Compare February 16, 2025 10:47
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Feb 16, 2025
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Feb 16, 2025
@th7nder th7nder requested a review from jmg-duarte February 17, 2025 00:28
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Feb 17, 2025
jmg-duarte
jmg-duarte previously approved these changes Feb 17, 2025
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Feb 17, 2025
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 17, 2025
@jmg-duarte jmg-duarte requested a review from aidan46 February 17, 2025 15:23
@jmg-duarte jmg-duarte self-requested a review February 17, 2025 15:57
@jmg-duarte jmg-duarte enabled auto-merge (squash) February 17, 2025 15:57
@jmg-duarte jmg-duarte merged commit c45ca8e into develop Feb 17, 2025
6 checks passed
@jmg-duarte jmg-duarte deleted the feat/747/porep-partitions branch February 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust proofs in PoRep for bigger sector sizes
3 participants