Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mater-cli): add support for stdin input #761

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Conversation

jmg-duarte
Copy link
Collaborator

Description

Partial fix for #757, will need fetch to stream the file to stdout.
Also "brings to light" the issue that is if the file needs to be fully loaded into memory.

Test it with

# extract
cat mater/lib/tests/fixtures/car_v2/spaceglenda_wrapped.car | cargo r -r -p mater-cli -- extract -
# convert
cat mater/lib/tests/fixtures/original/spaceglenda.jpg | cargo r -r -p mater-cli -- convert --overwrite -

@jmg-duarte jmg-duarte added this to the Phase 3 milestone Feb 17, 2025
@jmg-duarte jmg-duarte self-assigned this Feb 17, 2025
@jmg-duarte jmg-duarte added the ready for review Review is needed label Feb 17, 2025
@jmg-duarte jmg-duarte enabled auto-merge (squash) February 17, 2025 15:35
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 17, 2025
@jmg-duarte jmg-duarte merged commit d77119d into develop Feb 17, 2025
6 checks passed
@jmg-duarte jmg-duarte deleted the feat/stdin branch February 17, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants