Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for multiple proof types at the network level #762

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: add support for multiple proof types at the network level #762

merged 1 commit into from
Feb 18, 2025

Conversation

jmg-duarte
Copy link
Collaborator

Description

Replaces the proof storage value with a storage map, and all the changes that creates.

Closes #756

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?
  • Did you document new (or modified) APIs?

@jmg-duarte jmg-duarte added this to the Phase 3 milestone Feb 17, 2025
@jmg-duarte jmg-duarte self-assigned this Feb 17, 2025
@jmg-duarte jmg-duarte marked this pull request as draft February 17, 2025 17:49
@jmg-duarte jmg-duarte marked this pull request as ready for review February 17, 2025 19:16
@jmg-duarte jmg-duarte added the ready for review Review is needed label Feb 17, 2025
@jmg-duarte jmg-duarte enabled auto-merge (squash) February 18, 2025 07:50
aidan46
aidan46 previously approved these changes Feb 18, 2025
View reviewed changes
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 18, 2025
th7nder
th7nder requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it's weird that you didn't need to change maat?

@jmg-duarte jmg-duarte force-pushed the feat/756/proofs branch 2 times, most recently from 2eb982f to ceab337 Compare February 18, 2025 14:37
th7nder
th7nder previously requested changes Feb 18, 2025
View reviewed changes
cernicc
cernicc reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@cernicc cernicc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding the Konrad's comment. Looks good

@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 18, 2025
@jmg-duarte jmg-duarte merged commit 7f298e8 into develop Feb 18, 2025
6 checks passed
@jmg-duarte jmg-duarte deleted the feat/756/proofs branch February 18, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cernicc cernicc cernicc approved these changes

@aidan46 aidan46 aidan46 approved these changes

@Jinxit Jinxit Awaiting requested review from Jinxit

@pete-eiger pete-eiger Awaiting requested review from pete-eiger

@th7nder th7nder Awaiting requested review from th7nder

Assignees

@jmg-duarte jmg-duarte

Labels
ready for review Review is needed
Projects
None yet
Milestone
Phase 3
Development

Successfully merging this pull request may close these issues.

Network is exclusive to one proof size
4 participants
@jmg-duarte @cernicc @th7nder @aidan46