feat: refactor p2p node & merge retrieval functionality #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cernicc
requested review from
Jinxit,
th7nder,
jmg-duarte,
pete-eiger and
aidan46
aidan46
reviewed
Feb 27, 2025
aidan46
reviewed
Feb 27, 2025
aidan46
reviewed
Feb 27, 2025
aidan46
reviewed
Feb 27, 2025
jmg-duarte
reviewed
Feb 27, 2025
jmg-duarte
reviewed
Feb 28, 2025
jmg-duarte
approved these changes
Feb 28, 2025
aidan46
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR looks bigger than it is. It refactors the p2p part of the storage provider node and merges retrieval server functionality to the same
Behaviour. That was needed because, when the provider node registers its public multiaddress to the rendezvous node. That multiaddress is returned by the rendezvous node when the client requests a peer_id to multiaddress mapping.This brings us a step closer to resolving the content based on the deal_id. Next part is indexing deals with cooresponding payload cids. That mapping should probably be exposed over request_response protocol. The p2p protocol for that is needed because client will already be connected to the provider's node before starting the block retrieval. --- The missing part for the client is figuring out which block to request first.
Checklist
Many. This is the least ugly one.