Fix loginUser #43
Fix loginUser #43
Conversation
Fixed loginUser by sending information through a form data. I also change the library used for the request to "Request" because I don't know how to send form data with the previous one.
| rest.create<any>(url, { | ||
| additionalHeaders: { | ||
| "user-agent": "Reddit-Viewer / 2.0.0" | ||
| var request = require('request'); |
There was a problem hiding this comment.
Bad practice. Use import at start of file.
| additionalHeaders: { | ||
| "user-agent": "Reddit-Viewer / 2.0.0" | ||
| var request = require('request'); | ||
| var options = { |
There was a problem hiding this comment.
Bad practice. VAR is global scope. Use LET instead.
There was a problem hiding this comment.
Yeah, I should have worn you that I don't have a lot of experience in JavaScript 😅
I'll fix that next time
| if (response.statusCode === 200 && response.result && response.result.json) { | ||
| resolve(response.result.json.data); | ||
| }; | ||
| request(options, function (error: { message: any; }, response: { statusCode: string | number; result: { json: { data: any; }; }; body: any }) { |
There was a problem hiding this comment.
statusCode: string | number why string?
Is any necessary?
There was a problem hiding this comment.
I'll be honest, I generated that part using vscode "quick fix" thing.
I'll make it manually next time
| @@ -651,7 +651,6 @@ export async function getMine(data: IAPIData): Promise<IGenericResult<IListing<I | |||
| url += "limit=" + data.limit + "&"; | |||
| } | |||
| url += "raw_json=1"; | |||
| if(!data.cookie){ data.cookie = ""; } | |||
There was a problem hiding this comment.
Why did you remove this?
As far as I remember this fixed a bug where the old session was still used.
There was a problem hiding this comment.
I'm pretty sure I didn't remove that, and I don't think vscode would delete it for no reason so I might have made a bad manipulation.
| throw reject(error.message); | ||
| } | ||
| if (response.statusCode === 200 && response.body) { | ||
| var responseJson = JSON.parse( response.body ).json; |
There was a problem hiding this comment.
Better use let or const here here
| var responseJson = JSON.parse( response.body ).json; | |
| const responseJson = JSON.parse( response.body ).json; |
| } | ||
| if (response.statusCode === 200 && response.body) { | ||
| var responseJson = JSON.parse( response.body ).json; | ||
| if (responseJson.errors.length === 0) { |
There was a problem hiding this comment.
This code should check for falsy responseJson before accessing errors property.
| if (responseJson.errors.length === 0) { | |
| if (responseJson && responseJson.errors && responseJson.errors.length === 0) { |
Or it is better to add a function to check for validity of response like isValidResponseJson
| if (responseJson.errors.length === 0) { | |
| if (isValidResponseJson(responseJson)) { |
Fixed loginUser by sending information through a form data. I also change the library used for the request to "Request" because I don't know how to send form data with the previous one.
Again, this is my first contribution to a project so feel free to critique my work and modify it if you want.
What type of contribution is this?
Bug
New feature