Implement Serialize/Deserialize for DATE, TIME, and DATETIME#159
Open
imurasawa wants to merge 4 commits into
Open
Implement Serialize/Deserialize for DATE, TIME, and DATETIME#159imurasawa wants to merge 4 commits into
imurasawa wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Serialize/Deserialize for DATE, TIME, and DATETIME
Problem
Current state of
SerializeValue/DeserializeValueinProperty.cs:default: ToString()— worksDateTime.Parse()— worksdefault: ToString()— hundredths lostDateTime.Parse()— works, but hundredths already lostdefault: ToString()— writes something, but…default: null→ read returns nullFix
Added explicit cases for DATE, TIME, and DATETIME in both
SerializeValueandDeserializeValue, using the same ASCII format as bacnet-stack'sdatetime_to_ascii():yyyy/MM/ddHH:mm:ss.hh(hh = hundredths, 0–99)yyyy/MM/dd-HH:mm:ss.hhNote: C#'s
DateTimedoes not have a hundredths field, so the conversion usesMillisecond / 10.Verification
Read
OBJECT_DATETIME_VALUEfrom a separate Linux machine (Raspberry Pi 4) using bacnet-stack'sbacrp:The value was correctly decoded on the bacnet-stack side.
Note: the display format produced by
bacrpdiffers fromyyyy/MM/dd-HH:mm:ss.hh; this is due tobacrp's own display formatting, not the wire encoding.Notes
Storage/Property.csonly.