replace password with unix socket authentication for root user#9
Open
DanScharon wants to merge 3 commits intoelan-ev:mainfrom
Open
replace password with unix socket authentication for root user#9DanScharon wants to merge 3 commits intoelan-ev:mainfrom
DanScharon wants to merge 3 commits intoelan-ev:mainfrom
Conversation
… database_root_password optional and uses unix_socket as default auth plugin. Ensures that the tasks run for both Debian and RedHat based distros
Author
|
follow-up of #4 |
wsmirnow
requested changes
Nov 10, 2025
Contributor
wsmirnow
left a comment
wsmirnow
left a comment
There was a problem hiding this comment.
Hi @DanScharon, I'm sorry this review took a while.
I'm not sure of
- enabling unix socket authentication plugin for root user will also
- disable password based login for root
- only unix root user is allowed to run administrative tasks on DB server
- if this role should really take care about restricting access for root user,
- yes we did it in the previous version but is it the way to go?
- Maybe this feature should be configurable?
- what should the configuration looks like? Root Unix Auth: [true | false]?
What du you think about?
|
|
||
| - name: Wait for MariaDB start | ||
| ansible.builtin.wait_for: | ||
| path: "{{ '/run/mysqld/mysqld.sock' if ansible_os_family == 'Debian' else '/var/lib/mysql/mysql.sock' }}" |
Contributor
There was a problem hiding this comment.
Replace this to be consistent
Suggested change
| path: "{{ mariadb_socket_path }}" |
| @@ -97,6 +70,8 @@ | |||
| priv: "{{ database_name }}.*:ALL,GRANT" | |||
| login_user: "{{ database_root_user }}" | |||
| login_password: "{{ database_root_password }}" | |||
Contributor
There was a problem hiding this comment.
Password may be unset. This would handle this case.
Suggested change
| login_password: "{{ database_root_password }}" | |
| login_password: "{{ database_root_password | default(omit) }}" |
| @@ -105,30 +80,32 @@ | |||
| state: present | |||
| login_user: "{{ database_root_user }}" | |||
| login_password: "{{ database_root_password }}" | |||
Contributor
There was a problem hiding this comment.
Password may be unset. This would handle this case.
Suggested change
| login_password: "{{ database_root_password }}" | |
| login_password: "{{ database_root_password | default(omit) }}" |
| host_all: true | ||
| state: absent | ||
| login_user: "{{ database_root_user }}" | ||
| login_password: "{{ database_root_password }}" |
Contributor
There was a problem hiding this comment.
Password may be unset. This would handle this case.
Suggested change
| login_password: "{{ database_root_password }}" | |
| login_password: "{{ database_root_password | default(omit) }}" |
Comment on lines
98
to
+111
| - name: Ensure root user can only connect from the local machine | ||
| community.mysql.mysql_user: | ||
| user: "{{ database_root_user }}" | ||
| password: "{{ database_root_password }}" | ||
| host: "{{ item }}" | ||
| community.mysql.mysql_query: | ||
| query: | ||
| - DELETE FROM mysql.user WHERE User='root' AND Host NOT IN ('localhost', '127.0.0.1', '::1') | ||
| login_user: "{{ database_root_user }}" | ||
| login_password: "{{ database_root_password }}" | ||
| loop: | ||
| - "::1" | ||
| - "localhost" | ||
| - "{{ ansible_fqdn }}" | ||
| no_log: true | ||
| login_unix_socket: "{{ mariadb_socket_path }}" | ||
|
|
||
| - name: Ensure unix socket as login method for root user | ||
| community.mysql.mysql_user: | ||
| name: "{{ database_root_user }}" | ||
| plugin: unix_socket | ||
| check_implicit_admin: true | ||
| login_unix_socket: "{{ mariadb_socket_path }}" |
Contributor
There was a problem hiding this comment.
Enabling unix socket plugin for root user authentication will disallow password based authentication (see docs). IMO there is no need to run this query. Isn't it?
Suggested change
| - name: Ensure root user can only connect from the local machine | |
| community.mysql.mysql_user: | |
| user: "{{ database_root_user }}" | |
| password: "{{ database_root_password }}" | |
| host: "{{ item }}" | |
| community.mysql.mysql_query: | |
| query: | |
| - DELETE FROM mysql.user WHERE User='root' AND Host NOT IN ('localhost', '127.0.0.1', '::1') | |
| login_user: "{{ database_root_user }}" | |
| login_password: "{{ database_root_password }}" | |
| loop: | |
| - "::1" | |
| - "localhost" | |
| - "{{ ansible_fqdn }}" | |
| no_log: true | |
| login_unix_socket: "{{ mariadb_socket_path }}" | |
| - name: Ensure unix socket as login method for root user | |
| community.mysql.mysql_user: | |
| name: "{{ database_root_user }}" | |
| plugin: unix_socket | |
| check_implicit_admin: true | |
| login_unix_socket: "{{ mariadb_socket_path }}" | |
| - name: Ensure unix socket as login method for root user | |
| community.mysql.mysql_user: | |
| name: "{{ database_root_user }}" | |
| plugin: unix_socket | |
| check_implicit_admin: true | |
| login_unix_socket: "{{ mariadb_socket_path }}" |
Comment on lines
+8
to
+10
| # mariadb root user password, | ||
| # only used for authentication to a db with an already set root password and disabled unix_socket authentication | ||
| database_root_password: '4567' |
Contributor
There was a problem hiding this comment.
Stop setting default passwords, especially unsecure one!
Suggested change
| # mariadb root user password, | |
| # only used for authentication to a db with an already set root password and disabled unix_socket authentication | |
| database_root_password: '4567' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace password with unix socket authentication for root user. Make database_root_password optional and use unix_socket as default auth plugin. Ensure that the tasks run for both Debian and RedHat based distros