Node43 support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Id like if this was dynamic or configurable for posterity. Could we check the the webpack config or something? Also will this fix #1 ? |
|
Node 4 is LTS and all the dependencies will continue updating -- I'm not sure supporting the old version is critical. I'd be interested in seeing if serverless-runtime-babel got any pushback on their change but it doesn't seem like it. |
|
Can we get this on npm @thenikso |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch nodejs version to 4.3 (like serverless-runtime-babel did) and bump the version, See serverless/serverless-runtime-babel@79c87b2