Draft
Conversation
All the hard work was done in import-in-the-middle#28. Refs: #3445
Also had to uninstall/reinstall some dev deps because `npm` was unable to resolve where to correctly place 'acorn' (which has usage of @8 and @7 by various other deps) and 'acorn-import-assertions' (which has a peerDep on acorn@8). This unforunately resulted in updating some transitive deps, so it muddies the package-lock change somewhat.
Member
Author
|
That fails the ESM test attempting to use This is an import-in-the-middle issue, though I'm not exactly sure how tractable this will be in general. I've opened nodejs/import-in-the-middle#29 |
Member
Author
|
Note that we'll be updating to import-in-the-middle@1.4.2 in #3569 so this PR will need to be adjusted when we want to enable using node v20 and ESM. |
Contributor
|
what is missing here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the hard work was done in import-in-the-middle#28.
Refs: #3445