Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #42565) Add latency metrics for logstash async output #42584

Open
wants to merge 6 commits into
base: 8.17
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 4, 2025

Same as #42537 but for Logstash

#37445 added latency metrics for the sync output but the async output is what's used by the default configuration


This is an automatic backport of pull request #42565 done by Mergify.

* Add latency metrics for logstash async output

* Properly handle per-batch latency

(cherry picked from commit accc5e1)

# Conflicts:
#	libbeat/outputs/logstash/async.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 4, 2025
@mergify mergify bot requested a review from a team as a code owner February 4, 2025 06:44
Copy link
Contributor Author

mergify bot commented Feb 4, 2025

Cherry-pick of accc5e1 has failed:

On branch mergify/bp/8.17/pr-42565
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit accc5e147.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/outputs/logstash/async.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from AndersonQ and removed request for a team February 4, 2025 06:44
@mergify mergify bot requested a review from rdner February 4, 2025 06:44
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 4, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 5, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 5, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@strawgate strawgate enabled auto-merge (squash) February 5, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants