Skip to content

Monthly Manifest and Schema Updation#6036

Merged
shashank-elastic merged 4 commits into
mainfrom
may_schema_update
May 4, 2026
Merged

Monthly Manifest and Schema Updation#6036
shashank-elastic merged 4 commits into
mainfrom
may_schema_update

Conversation

@shashank-elastic

Copy link
Copy Markdown
Contributor

Pull Request

Issue link(s): As part of release https://github.com/elastic/ia-trade-team/issues/876

Summary - What I changed

How To Test

  • Unit Tests should pass

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a new schema feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Ensure that the code is modular and reusable where applicable.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.
  • Conducted system testing, including fleet, import, and create APIs (e.g., run make test-cli, make test-remote-cli, make test-hunting-cli)

Additional Schema Related Checks

  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Link to the relevant Kibana PR or issue provided
  • Test export/import flow:
    • Exported detection rule(s) from Kibana to showcase the feature(s)
    • Converted the exported ndjson file(s) to toml in the detection-rules repo
    • Re-exported the toml rule(s) to ndjson and re-imported into Kibana
  • Updated necessary unit tests to accommodate the feature
  • Incorporated a comprehensive test rule in unit tests for full schema coverage
  • Applied min_compat restrictions to limit the feature to a specified minimum stack version
  • Executed all unit tests locally with a test toml rule to confirm passing
  • Included Kibana PR implementer as an optional reviewer for insights on the feature
  • Implemented requisite downgrade functionality
  • Cross-referenced the feature with product documentation for consistency
  • Confirm that the proper version label is applied to the PR patch, minor, major.

@botelastic botelastic Bot added Domain: Endpoint OS: Windows windows related rules labels May 4, 2026
@shashank-elastic shashank-elastic added patch and removed OS: Windows windows related rules Domain: Endpoint labels May 4, 2026
@tradebot-elastic

tradebot-elastic commented May 4, 2026

Copy link
Copy Markdown

⛔️ Test failed

Results
  • ❌ Microsoft IIS Service Account Password Dumped (eql)
    • stack_validation_failed: no_alerts - 0 alerts

@botelastic botelastic Bot added Domain: Endpoint OS: Windows windows related rules labels May 4, 2026
@tradebot-elastic

tradebot-elastic commented May 4, 2026

Copy link
Copy Markdown

⛔️ Test failed

Results
  • ❌ Microsoft IIS Service Account Password Dumped (eql)
    • stack_validation_failed: no_alerts - 0 alerts

@shashank-elastic shashank-elastic merged commit a6fba3c into main May 4, 2026
16 checks passed
@shashank-elastic shashank-elastic deleted the may_schema_update branch May 4, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants