-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax quick ref #834
Add syntax quick ref #834
Conversation
@marciw I started adding some elements, mainly to test the layout. Feel free to modify it where needed :) |
@alaudazzi I pushed a commit with an example entry -- see the issue for more details |
@marciw it seems that the Headings in the Output example are taken into account on the right TOC: |
Co-authored-by: Jan Calanog <[email protected]>
Co-authored-by: Jan Calanog <[email protected]>
@marciw Thanks for your last edits, it looks nice! We can always iterate if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@reakaleek does this look OK to you now? I think it's good to go (but need codeowner approval) 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
```markdown | ||
```json | ||
{ | ||
"match": { | ||
"message": "search text" // Searches the message field | ||
} | ||
} | ||
``` | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I guess this is supposed to be json, not markdown.
```markdown | |
```json | |
{ | |
"match": { | |
"message": "search text" // Searches the message field | |
} | |
} | |
``` | |
``` | |
```json | |
{ | |
"match": { | |
"message": "search text" // Searches the message field | |
} | |
} | |
``` |
Thanks, y'all!! |
Add a syntax quick reference with brief guidance that points to the full syntax guide.
Preview
https://github.com/elastic/docs-projects/issues/458