-
Notifications
You must be signed in to change notification settings - Fork 182
Fix serverless applicability in setting up data streams docs #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #3384 and updates the page so that it can be used for both Stack and Serverless scopes.
Vale Linting ResultsSummary: 1 warning found
|
| File | Line | Rule | Message |
|---|---|---|---|
| manage-data/data-store/data-streams/set-up-data-stream.md | 314 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
🔍 Preview links for changed docs |
kilfoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🌲
I love having these tabs with the UI steps and I think it's much clearer now that the first step applies only to non-Serverless users. Looks great!
My suggestions are all just super minor things.
marciw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice; this is much clearer! Mostly minor comments
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
|
Thanks folks! 🙌 |
Fixes #3384 and updates the page so that it can be used for both Stack and Serverless scopes.
Summary
I've added a bit more context around the step to create an ILM policy included in this tutorial, and why it is not required in a Serverless context.
I've also added tabs to the sections that list both Kibana steps and steps using the API. Each section now also links to the corresponding Serverless API doc page.
Generative AI disclosure