Fixing two invalid links #4151
Merged
Fixing two invalid links #4151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing two invalid links from `azure` to `gcp`
✅ Vale Linting ResultsNo issues found on modified lines! |
🔍 Preview links for changed docs |
florent-leborgne
previously requested changes
Dec 1, 2025
Contributor
florent-leborgne
left a comment
florent-leborgne
left a comment
There was a problem hiding this comment.
I think these are supposed to keep users on the same page since these sections are visibly there too. The current links and the suggested fixes send users to a different page, which looks strange to me, and if correct would make me question why do we have those sections after on the page :D
Thanks for finding them and attempting a fix.
Co-authored-by: florent-leborgne <[email protected]>
benironside
approved these changes
Dec 1, 2025
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
Tested the links in the preview and they're working
benironside
dismissed
florent-leborgne’s stale review
Dismissing florent's review because I incorporated his suggestion and the PR now works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing two invalid links from
azuretogcpSummary
Generative AI disclosure