-
Notifications
You must be signed in to change notification settings - Fork 200
Update ES exporter docs #11017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update ES exporter docs #11017
Conversation
🔍 Preview links for changed docs |
vishaangelova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple of suggestions for your consideration
docs/reference/edot-collector/components/elasticsearchexporter.md
Outdated
Show resolved
Hide resolved
docs/reference/edot-collector/components/elasticsearchexporter.md
Outdated
Show resolved
Hide resolved
docs/reference/edot-collector/components/elasticsearchexporter.md
Outdated
Show resolved
Hide resolved
docs/reference/edot-collector/components/elasticsearchexporter.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Visha Angelova <[email protected]>
vishaangelova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
|
|
||
| :::{note} | ||
| The `flush::interval` config is ignored when `batcher::enabled` config is explicitly set to true or false. | ||
| The `flush::interval` config is ignored when using `sending_queue` (enabled by default) or when `batcher::enabled` config is explicitly set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this statement is either correct or incorrect depending on which version we're on, but this line doesn't have applies_to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version would it be true for?
| The {{es}} exporter supports the common `sending_queue` settings, which enable both queuing and batching. The default sending queue is configured to do async batching with the following configuration: | ||
|
|
||
| ```yaml | ||
| sending_queue: | ||
| enabled: true | ||
| num_consumers: runtime.NumCPU() | ||
| queue_size: <based on queue.mem.events> | ||
| block_on_overflow: true | ||
| wait_for_result: true | ||
| batch: | ||
| flush_timeout: 10s | ||
| min_size: 0 | ||
| max_size: <based on flush::bytes> | ||
| sizer: items | ||
| ``` | ||
| ### Internal batching (default) | ||
| By default, the exporter performs its own buffering and batching, as configured through the `flush` setting, unless the `sending_queue::batch` or the `batcher` settings are defined. In that case, batching is controlled by either of the two settings, depending on the version. | ||
|
|
||
| ### Custom batching | ||
| The default configurations are chosen to be closer to the defaults with the exporter's previous built-in batching feature. For more details on the `sending_queue` settings, refer to the [`exporterhelper` documentation](https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm afraid these need to be in a applies_to 9.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the default configs? If that's the case, we could put the PR on hold till 9.3 is up.
| min_size: 1000 | ||
| max_size: 10000 | ||
| timeout: 5s | ||
| flush_timeout: 5s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
docs/reference/edot-collector/components/elasticsearchexporter.md
Outdated
Show resolved
Hide resolved
docs/reference/edot-collector/components/elasticsearchexporter.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Vishal Raj <[email protected]>
| :::{applies-item} stack: ga 9.0, deprecated 9.2 | ||
| ### Deprecated batcher configuration | ||
| ```{applies_to} | ||
| stack: ga 9.0, deprecated 9.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, batcher is now removed from the config. Do we add something here for this for the 9.3 version to signal that batcher is no longer there?
|
@carsonip @lahsivjar PTAL |
This updates the ES exporter docs based on the 0.138.0 changes.
Created using Cursor 2 on auto model rotation. I provided the latest ES Exporter README to the LLM to update the docs, then made some light edits.