Skip to content

Conversation

@theletterf
Copy link
Contributor

@theletterf theletterf commented Nov 4, 2025

This updates the ES exporter docs based on the 0.138.0 changes.


Created using Cursor 2 on auto model rotation. I provided the latest ES Exporter README to the LLM to update the docs, then made some light edits.

@theletterf theletterf requested a review from a team as a code owner November 4, 2025 11:50
@theletterf theletterf self-assigned this Nov 4, 2025
@theletterf theletterf added skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🔍 Preview links for changed docs

@theletterf theletterf requested a review from carsonip November 4, 2025 11:53
@carsonip carsonip requested a review from lahsivjar November 4, 2025 18:51
vishaangelova
vishaangelova previously approved these changes Nov 5, 2025
Copy link
Contributor

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple of suggestions for your consideration

vishaangelova
vishaangelova previously approved these changes Nov 5, 2025
Copy link
Contributor

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

vishaangelova
vishaangelova previously approved these changes Nov 5, 2025

:::{note}
The `flush::interval` config is ignored when `batcher::enabled` config is explicitly set to true or false.
The `flush::interval` config is ignored when using `sending_queue` (enabled by default) or when `batcher::enabled` config is explicitly set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this statement is either correct or incorrect depending on which version we're on, but this line doesn't have applies_to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version would it be true for?

Comment on lines 136 to 152
The {{es}} exporter supports the common `sending_queue` settings, which enable both queuing and batching. The default sending queue is configured to do async batching with the following configuration:

```yaml
sending_queue:
enabled: true
num_consumers: runtime.NumCPU()
queue_size: <based on queue.mem.events>
block_on_overflow: true
wait_for_result: true
batch:
flush_timeout: 10s
min_size: 0
max_size: <based on flush::bytes>
sizer: items
```
### Internal batching (default)
By default, the exporter performs its own buffering and batching, as configured through the `flush` setting, unless the `sending_queue::batch` or the `batcher` settings are defined. In that case, batching is controlled by either of the two settings, depending on the version.

### Custom batching
The default configurations are chosen to be closer to the defaults with the exporter's previous built-in batching feature. For more details on the `sending_queue` settings, refer to the [`exporterhelper` documentation](https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/README.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm afraid these need to be in a applies_to 9.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the default configs? If that's the case, we could put the PR on hold till 9.3 is up.

min_size: 1000
max_size: 10000
timeout: 5s
flush_timeout: 5s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

:::{applies-item} stack: ga 9.0, deprecated 9.2
### Deprecated batcher configuration
```{applies_to}
stack: ga 9.0, deprecated 9.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, batcher is now removed from the config. Do we add something here for this for the 9.3 version to signal that batcher is no longer there?

@theletterf
Copy link
Contributor Author

@carsonip @lahsivjar PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants