-
Notifications
You must be signed in to change notification settings - Fork 200
[otel] add awslogsencodingextension #11078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[otel] add awslogsencodingextension #11078
Conversation
|
This pull request does not have a backport label. Could you fix it @mykola-elastic? 🙏
|
💚 Build Succeeded
History
|
ebeahan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@ebeahan thanks for the review. If you are OK with it, feel free to press the merge button (I don't have permissions to merge) |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
What does this PR do?
Adds
awslogsencodingextensionto EDOT collectorWhy is it important?
awss3receiver(added in #10515) is quite useless withoutawslogsencodingextensionwhich unmarshals logs encoded in formats produced by AWS services.Adding
awslogsencodingextensionwould enable us to create input otel package for AWS VPC Flow Logs, ELB Access Logs, Cloudtrail logs, etc.cc @ishleenk17, @tommyers-elastic
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E test