Skip to content

Conversation

@mykola-elastic
Copy link
Contributor

@mykola-elastic mykola-elastic commented Nov 7, 2025

What does this PR do?

Adds awslogsencodingextension to EDOT collector

Why is it important?

awss3receiver (added in #10515) is quite useless without awslogsencodingextension which unmarshals logs encoded in formats produced by AWS services.

Adding awslogsencodingextension would enable us to create input otel package for AWS VPC Flow Logs, ELB Access Logs, Cloudtrail logs, etc.

cc @ishleenk17, @tommyers-elastic

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2025

This pull request does not have a backport label. Could you fix it @mykola-elastic? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mykola-elastic

@mykola-elastic mykola-elastic marked this pull request as ready for review November 7, 2025 14:12
@mykola-elastic mykola-elastic requested a review from a team as a code owner November 7, 2025 14:12
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mykola-elastic
Copy link
Contributor Author

mykola-elastic commented Nov 7, 2025

@ebeahan thanks for the review. If you are OK with it, feel free to press the merge button (I don't have permissions to merge)

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b edot-add-awslogsencodingextension upstream/edot-add-awslogsencodingextension
git merge upstream/main
git push upstream edot-add-awslogsencodingextension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants