Skip to content

Conversation

@l-trotta
Copy link
Contributor

Closes #90.
Adds an overload setter to Time so that it can be built using an integer and a TimeUnit, instead of just a plain string.

Old builder example:

OpenPointInTimeRequest opr = OpenPointInTimeRequest.of(o -> o
    .index("test")
    .keepAlive(k -> k
        .time("5s") // plain string was the only way
    )
);

New builder example:

OpenPointInTimeRequest opr = OpenPointInTimeRequest.of(o -> o
    .index("test")
    .keepAlive(k -> k
        .time(5, TimeUnit.Seconds) // TimeUnit provides all accepted units
    )
);

@l-trotta l-trotta merged commit cf8b6fd into main Jan 16, 2026
17 checks passed
@l-trotta l-trotta deleted the time-overload branch January 16, 2026 17:48
@github-actions
Copy link

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-1141-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 cf8b6fd3501b76cf5e88d6e96407d977b8b5f30a
# Push it to GitHub
git push --set-upstream origin backport-1141-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-1141-to-8.19.

@github-actions
Copy link

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-1141-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 cf8b6fd3501b76cf5e88d6e96407d977b8b5f30a
# Push it to GitHub
git push --set-upstream origin backport-1141-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-1141-to-9.1.

@github-actions
Copy link

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-1141-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 cf8b6fd3501b76cf5e88d6e96407d977b8b5f30a
# Push it to GitHub
git push --set-upstream origin backport-1141-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-1141-to-9.2.

github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
* better builder for time

* checkstyle
@l-trotta
Copy link
Contributor Author

failing backports don't matter as branches will be regenerated.

l-trotta added a commit that referenced this pull request Jan 16, 2026
* better builder for time

* checkstyle

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better way to construct time/duration values?

2 participants