-
Notifications
You must be signed in to change notification settings - Fork 283
Better builder for Time #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better builder for Time #1141
Conversation
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-1141-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 cf8b6fd3501b76cf5e88d6e96407d977b8b5f30a
# Push it to GitHub
git push --set-upstream origin backport-1141-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-1141-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 cf8b6fd3501b76cf5e88d6e96407d977b8b5f30a
# Push it to GitHub
git push --set-upstream origin backport-1141-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-1141-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 cf8b6fd3501b76cf5e88d6e96407d977b8b5f30a
# Push it to GitHub
git push --set-upstream origin backport-1141-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2Then, create a pull request where the |
* better builder for time * checkstyle
|
failing backports don't matter as branches will be regenerated. |
* better builder for time * checkstyle Co-authored-by: Laura Trotta <[email protected]>
Closes #90.
Adds an overload setter to Time so that it can be built using an integer and a TimeUnit, instead of just a plain string.
Old builder example:
New builder example: