Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch BulkIndexError exception in async_bulk. resolves #864 #2208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Catch BulkIndexError exception in async_bulk. resolves #864 #2208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions elasticsearch/_async/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
_process_bulk_chunk_success,
expand_action,
)
from ..helpers.errors import ScanError
from ..helpers.errors import ScanError, BulkIndexError
from ..serializer import Serializer
from .client import AsyncElasticsearch # noqa

Expand Down Expand Up @@ -334,10 +334,18 @@ async def async_bulk(

# make streaming_bulk yield successful results so we can count them
kwargs["yield_ok"] = True
async for ok, item in async_streaming_bulk(
async_streaming_bulk_itr = async_streaming_bulk(
client, actions, ignore_status=ignore_status, *args, **kwargs # type: ignore[misc]
):
# go through request-response pairs and detect failures
)
# go through request-response pairs and detect failures
while True:
try:
ok, item = await anext(async_streaming_bulk_itr)
except StopAsyncIteration:
break
except BulkIndexError as e:
ok, item = False, e.errors[0]

if not ok:
if not stats_only:
errors.append(item)
Expand Down