Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add querying docs #2843

Merged
merged 6 commits into from
Apr 2, 2025
Merged

Add querying docs #2843

merged 6 commits into from
Apr 2, 2025

Conversation

pquentin
Copy link
Member

It's not always obvious to go from an API to a function call, and this page contains the details.

It's not always obvious to go from an API to a function call, and this page
contains the details.
@pquentin pquentin requested a review from miguelgrinberg March 14, 2025 13:49


:::{image} ../images/python-example.png
:alt: Python code example in the Elasticsearch guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense for 8.x releases, but in 9.0 the examples are not going to have client language versions, at least not initially.

Copy link
Contributor

@miguelgrinberg miguelgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments and suggestions that you are welcome to ignore if you disagree.

@pquentin pquentin requested a review from miguelgrinberg April 2, 2025 12:29
@pquentin pquentin merged commit 3fcb719 into elastic:main Apr 2, 2025
14 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 2, 2025
* Add querying docs

It's not always obvious to go from an API to a function call, and this page
contains the details.

* Apply suggestions from code review

Co-authored-by: Miguel Grinberg <[email protected]>

* Address more comments

* Rename to Querying for consistency

* Clarify that examples in guide depend on version

---------

Co-authored-by: Miguel Grinberg <[email protected]>
(cherry picked from commit 3fcb719)
pquentin added a commit that referenced this pull request Apr 2, 2025
* Add querying docs

It's not always obvious to go from an API to a function call, and this page
contains the details.

* Apply suggestions from code review

Co-authored-by: Miguel Grinberg <[email protected]>

* Address more comments

* Rename to Querying for consistency

* Clarify that examples in guide depend on version

---------

Co-authored-by: Miguel Grinberg <[email protected]>
(cherry picked from commit 3fcb719)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants