-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add querying docs #2843
Add querying docs #2843
Conversation
It's not always obvious to go from an API to a function call, and this page contains the details.
|
||
|
||
:::{image} ../images/python-example.png | ||
:alt: Python code example in the Elasticsearch guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense for 8.x releases, but in 9.0 the examples are not going to have client language versions, at least not initially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments and suggestions that you are welcome to ignore if you disagree.
* Add querying docs It's not always obvious to go from an API to a function call, and this page contains the details. * Apply suggestions from code review Co-authored-by: Miguel Grinberg <[email protected]> * Address more comments * Rename to Querying for consistency * Clarify that examples in guide depend on version --------- Co-authored-by: Miguel Grinberg <[email protected]> (cherry picked from commit 3fcb719)
* Add querying docs It's not always obvious to go from an API to a function call, and this page contains the details. * Apply suggestions from code review Co-authored-by: Miguel Grinberg <[email protected]> * Address more comments * Rename to Querying for consistency * Clarify that examples in guide depend on version --------- Co-authored-by: Miguel Grinberg <[email protected]> (cherry picked from commit 3fcb719) Co-authored-by: Quentin Pradet <[email protected]>
It's not always obvious to go from an API to a function call, and this page contains the details.