-
Notifications
You must be signed in to change notification settings - Fork 96
Add search_inference_id property #3901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search_inference_id property #3901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to break this into two separate PRs. The search_inference_id
was added in 8.16 (see #113051), but inference_id
was made optional in 8.17.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed internally and we can merge this PR and make a separate one only for search_inference_id
for 8.16
* feat: add search_inference_id property * fix: run make * Add descriptions for parameters * Mark inference_id as optional * Add inference_id server default --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3901-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e4cedeed985b83c9bea600012d0201ae2ab38b2d
# Push it to GitHub
git push --set-upstream origin backport-3901-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
* feat: add search_inference_id property * fix: run make * Add descriptions for parameters * Mark inference_id as optional * Add inference_id server default --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-3901-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e4cedeed985b83c9bea600012d0201ae2ab38b2d
# Push it to GitHub
git push --set-upstream origin backport-3901-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
--------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee)
* feat: add search_inference_id property * fix: run make * Add descriptions for parameters * Mark inference_id as optional * Add inference_id server default --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee)
* feat: add search_inference_id property * fix: run make * Add descriptions for parameters * Mark inference_id as optional * Add inference_id server default --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee) Co-authored-by: Sergey Tihon <[email protected]>
* feat: add search_inference_id property * fix: run make * Add descriptions for parameters * Mark inference_id as optional * Add inference_id server default --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee) Co-authored-by: Sergey Tihon <[email protected]>
* feat: add search_inference_id property * fix: run make * Add descriptions for parameters * Mark inference_id as optional * Add inference_id server default --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee) Co-authored-by: Sergey Tihon <[email protected]>
--------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e4cedee) Co-authored-by: Sergey Tihon <[email protected]>
Fixes/unblock: elastic/elasticsearch-net#8467
Add property mentioned in docs https://www.elastic.co/guide/en/elasticsearch/reference/current/semantic-text.html#semantic-text-params but missing in the specification.
Closes #3923