Skip to content

Remove number_of_shards setting from clone API example #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025
Merged

Remove number_of_shards setting from clone API example #5073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfc8d73
Remove `number_of_shards` setting from clone API example
PeteGillinElastic Aug 4, 2025
5f7d20c
Respond to comment from Lee
PeteGillinElastic Aug 4, 2025
800341e
Merge branch 'main' into clone-indices-example-remove-number-of-shards
PeteGillinElastic Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion output/openapi/elasticsearch-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion specification/indices/clone/examples/request/indicesCloneRequestExample1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ value: "{

\ \"settings\": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the description says "The API accepts settings and aliases parameters for the target index", can we keep an example of updating the settings here? Perhaps we can use index.refresh_interval instead of the primary shards one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good idea. Done. (I had considered doing something like this, but I couldn't think of any settings that one would be likely to specify while cloning. I would guess that most clones are "clean" copies, though I could be wrong.)


\ \"index.number_of_shards\": 5
\ \"index.refresh_interval\": \"2s\"

\ },

Expand Down