[8.x] Add Bounded Window to Inference Models for Rescoring to Ensure Positive Score Range (#125694)#126149
Merged
markjhoy merged 1 commit intoelastic:8.xfrom Apr 23, 2025
Merged
Conversation
…ve Score Range (elastic#125694) * apply bounded window inference model * linting * add unit tests * [CI] Auto commit changes from spotless * add additional tests * remove unused constructor --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit e77bf80)
Samiul-TheSoccerFan
approved these changes
Apr 2, 2025
kderusso
approved these changes
Apr 2, 2025
Member
kderusso
left a comment
There was a problem hiding this comment.
LGTM, do we want to backport this to 9.0 too?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation