Update test container version to 2.0.2 #138622
Open
+384
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
breskeby
added
auto-backport
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
commented
Nov 25, 2025
| components.withModule("org.subethamail:subethasmtp", ExcludeAllTransitivesRule.class); | ||
|
|
||
| // Testcontainers dependencies | ||
| components.withModule("org.testcontainers:testcontainers", ExcludeAllTransitivesRule.class); |
Contributor
Author
There was a problem hiding this comment.
We lately have removed our requirement for no transitive dependencies. lets rely on transitives here for docker java etc.
breskeby
commented
Nov 25, 2025
| testImplementation project(':test:framework') | ||
| api "junit:junit:${versions.junit}" | ||
| api project(':test:fixtures:testcontainer-utils') | ||
| api("org.testcontainers:testcontainers:${versions.testcontainer}") { |
Contributor
Author
There was a problem hiding this comment.
some more dependency cleanup
breskeby
commented
Nov 25, 2025
| api("org.testcontainers:testcontainers:${versions.testcontainer}") { | ||
| transitive = false | ||
| } | ||
| implementation("commons-io:commons-io:2.15.1") |
Contributor
Author
There was a problem hiding this comment.
we rely on IOUtils which we previously used a shaded class shipped with testcontainer
breskeby
commented
Nov 25, 2025
| super(image); | ||
| } | ||
|
|
||
| @Override |
Contributor
Author
There was a problem hiding this comment.
wrap this in a junit4 rule api
breskeby
commented
Nov 25, 2025
| import org.junit.runners.model.Statement; | ||
| import org.testcontainers.containers.Network; | ||
|
|
||
| public class Junit4NetworkRule implements TestRule { |
Contributor
Author
There was a problem hiding this comment.
Util class to keep support for Network as rule
neilbhavsar
approved these changes
Nov 25, 2025
Contributor
|
Is anything needed for serverless? Or is this everything? |
breskeby
force-pushed
the
update-testcontainer-version
branch
from
3e7102c to
6f76ccc
Compare
elasticsearchmachine
added
the
serverless-linked
breskeby
force-pushed
the
update-testcontainer-version
branch
2 times, most recently
from
f510430 to
d3506c4
Compare
Contributor
Author
Yes, we have a linked PR addressing these |
breskeby
force-pushed
the
update-testcontainer-version
branch
2 times, most recently
from
2fabf10 to
6f59bf2
Compare
Wrap for junit4 support
- fix startup - stop failing silently - handle jarhell in shadowed commons
should simplify debugging cleanup failures
- using in parallel - using with weired Locale settings
breskeby
force-pushed
the
update-testcontainer-version
branch
from
bc1cd2d to
97a9cd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update testcontainer library due to docker incompatibility