Stop getSafeCommitInfo() blocking on engine reset #138753
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change IndexShard.getSafeCommitInfo() to stop blocking on engine reset. This eliminates deadlock risk between engine reset and retention lease syncing. Relates ES-13669
yungene
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
v9.3.0
serverless-linked
elasticsearchmachine
added
the
Team:Distributed Indexing
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change IndexShard.getSafeCommitInfo() to stop blocking on engine reset. This eliminates deadlock risk between engine reset and retention lease syncing.
This method is currently only used by the ReplicationTracker within getMinimumReasonableRetainedSeqNo(). If the engine is being reset, then this should result in no retention leases being expired for that attempt. I think this is acceptable as AsyncRetentionLeaseSyncTask runs every 30s, so leases will eventually be expired in another run.
Relates ES-13669