Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[awsfirehose] Avoid using dynamic templates for flattened objects #12570

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Feb 3, 2025

Proposed commit message

Update flattened field definitions to not create dynamic templates.

As they were previously, this dynamic template is created

  "dynamic_templates": [
    {
      "aws.firehose.parameters.*": {
        "path_match": "aws.firehose.parameters.*",
        "mapping": {
          "type": "flattened"
        },
        "match_mapping_type": "object"
      }
    }
  ],

but this definition does not match the fields under aws.firehose.parameters.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

How to test this PR locally

Run elastic-package with mappings validation enabled and run system tests:

cd packages/awsfirehose
elastic-package stack up -v -d --version <kibana_constraint>
export ELASTIC_PACKAGE_FIELD_VALIDATION_TEST_METHOD=mappings
# Add defer-cleanup to check the data ingested in the corresponding indices/data streams
elastic-package test system -v --defer-cleanup 900s

elastic-package stack down -v

Related issues

Screenshots

@mrodm mrodm self-assigned this Feb 3, 2025
@andrewkroh andrewkroh added the Integration:awsfirehose Amazon Data Firehose label Feb 3, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added Integration:1password 1Password Integration:abnormal_security Abnormal Security New Integration Issue or pull request for creating a new integration package. labels Feb 4, 2025
@mrodm mrodm force-pushed the update_awsfirehose_mappings branch from 18e1e54 to 96c5445 Compare February 4, 2025 10:07
@mrodm mrodm removed New Integration Issue or pull request for creating a new integration package. Integration:1password 1Password Integration:abnormal_security Abnormal Security labels Feb 4, 2025
@mrodm mrodm force-pushed the update_awsfirehose_mappings branch 3 times, most recently from 770b930 to b44964e Compare February 5, 2025 18:08
@mrodm mrodm force-pushed the update_awsfirehose_mappings branch from b44964e to 800dc65 Compare February 6, 2025 12:55
@@ -27,7 +27,7 @@
type: keyword
description: |
Firehose request ID.
- name: parameters.*
- name: parameters
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change to this definition makes sense for the expected documents?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is probably the expected use.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mrodm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:awsfirehose Amazon Data Firehose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants