-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[awsfirehose] Avoid using dynamic templates for flattened objects #12570
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
18e1e54
to
96c5445
Compare
770b930
to
b44964e
Compare
…41bb116f37d13f2d4e04502d0
(cherry picked from commit fa96beb)
b44964e
to
800dc65
Compare
@@ -27,7 +27,7 @@ | |||
type: keyword | |||
description: | | |||
Firehose request ID. | |||
- name: parameters.* | |||
- name: parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change to this definition makes sense for the expected documents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is probably the expected use.
This reverts commit 800dc65.
💚 Build Succeeded
History
cc @mrodm |
|
Proposed commit message
Update flattened field definitions to not create dynamic templates.
As they were previously, this dynamic template is created
but this definition does not match the fields under
aws.firehose.parameters
.Checklist
changelog.yml
file.Author's Checklist
elastic-package
enabled mappings: https://buildkite.com/elastic/integrations/builds/21926.buildkite
folderHow to test this PR locally
Run elastic-package with mappings validation enabled and run system tests:
Related issues
Screenshots