-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security service integrations packages mappings #12624
base: main
Are you sure you want to change the base?
Changes from all commits
01ba124
001e81e
a72f5b4
69d5f8a
ee10501
612ce1f
1420345
ef021f2
d048cc2
0abc3c4
0bcb54c
f74e314
698dbe9
1469158
a9736cc
2415ff2
75c3cec
8d215d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# This definition could be removed once Kibana constraint is updated | ||
# to 8.15.2 or higher. "ecs@mappings" component template would define | ||
# the correct dynamic template for it. | ||
- external: ecs | ||
name: threat.enrichments.indicator.first_seen | ||
- external: ecs | ||
name: threat.enrichments.indicator.last_seen | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# This definition could be removed once Kibana constraint is updated | ||
# to 8.15.2 or higher. "ecs@mappings" component template would define | ||
# the correct dynamic template for it. | ||
- external: ecs | ||
name: threat.indicator.modified_at | ||
Comment on lines
+4
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as in
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ | |
type: long | ||
- name: AsepWrittenCount | ||
type: long | ||
- name: assessments.* | ||
- name: assessments | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the fields under assessments were not defined (no mappings for it). |
||
type: flattened | ||
- name: AssociatedFile | ||
type: keyword | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,3 +38,5 @@ | |
name: rule.name | ||
- external: ecs | ||
name: tags | ||
- external: ecs | ||
name: message | ||
Comment on lines
+41
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Error:
In the data stream does not fail, because the mapping for that field is set by the |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ source: | |
# that ability in order to prevent having duplicate data and prevent query | ||
# time field type conflicts. | ||
dest: | ||
index: "logs-github_latest.dest_code_scanning-1" | ||
index: "logs-github_latest.dest_code_scanning-2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If a new field definition is added to a transform, should this destination index be updated (increment suffix number)? Same doubt for the other packages updating field definitions in transforms (tychon and wiz). |
||
aliases: | ||
- alias: "logs-github_latest.code_scanning" | ||
move_on_creation: true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# This definition could be removed once Kibana constraint is updated | ||
# to 8.15.2 or higher. "ecs@mappings" component template would define | ||
# the correct dynamic template for it. | ||
- external: ecs | ||
name: threat.indicator.modified_at | ||
- external: ecs | ||
name: threat.indicator.first_seen | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# This definition could be removed once Kibana constraint is updated | ||
# to 8.15.2 or higher. "ecs@mappings" component template would define | ||
# the correct dynamic template for it. | ||
- external: ecs | ||
name: threat.indicator.modified_at | ||
- external: ecs | ||
name: threat.indicator.first_seen | ||
Comment on lines
+4
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These two fields are mapped as keywords but they should
Using external |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -641,9 +641,22 @@ | |
- name: type | ||
type: keyword | ||
description: The type of authentication result, derived from the field name. | ||
# https://github.com/elastic/kibana/pull/204104 | ||
# Option 1: generate all keys as keywords under fields | ||
# - name: fields | ||
# type: object | ||
# object_type: keyword | ||
# object_type_mapping_type: "*" | ||
# Option 2: keep position as long | ||
- name: fields | ||
type: object | ||
object_type: keyword | ||
type: group | ||
fields: | ||
- name: "*" | ||
type: object | ||
object_type: keyword | ||
- name: position | ||
# description: ? | ||
type: long | ||
Comment on lines
+644
to
+659
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What option should we use here for The first one would map Should it be added descriptions to those fields? If so, could you provide them? |
||
- name: index | ||
type: long | ||
description: Index indicates the order in which a hop occurred from sender to recipient. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# This definition could be removed once Kibana constraint is updated | ||
# to 8.15.2 or higher. "ecs@mappings" component template would define | ||
# the correct dynamic template for it. | ||
- external: ecs | ||
name: threat.indicator.modified_at | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields were mapped as
keyword
, but they should bedate
according to ECS:Added field definitions for them using external.