Update logstash owner in manifest #12630
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Feb 5, 2025
| @@ -18,7 +18,7 @@ conditions: | |||
| elastic: | |||
| subscription: basic | |||
| owner: | |||
| github: elastic/stack-monitoring | |||
| github: elastic/logstash | |||
There was a problem hiding this comment.
Would it be needed to release a new version of this package with this change ?
cc @elastic/ecosystem
There was a problem hiding this comment.
I don't think a release is required given that this has no user-observable effect.
andrewkroh
approved these changes
Feb 5, 2025
4 tasks
qcorporation
requested review from
belimawr,
khushijain21,
gizas and
constanca-m
andrewkroh
force-pushed
the
update_owner_logstash
branch
from
909ff22 to
ee44233
Compare
andrewkroh
removed request for
a team,
belimawr,
khushijain21,
gizas and
constanca-m
💚 Build Succeeded
History
cc @mrodm |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Update
logstashowner in the package manifest to be the same defined in.github/CODEOWNERSfile.This difference between
.github/CODEOWNERSand the package manifest is causing errors in builds triggered from PRs. Example: https://buildkite.com/elastic/integrations/builds/21798Related issues