fix: address golangci-lint warnings #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
fix/linter-warnings
branch
5 times, most recently
from
8523016 to
ba94778
Compare
andrewkroh
added
the
Team:Security-Service Integrations
I think this reduces clarity when there are multiple embedded structs.
andrewkroh
force-pushed
the
fix/linter-warnings
branch
from
dbd2027 to
57a65cf
Compare
Replace tools.go with go mod tool directives. go get -tool github.com/golangci/golangci-lint/v2/cmd/golangci-lint go get -tool github.com/elastic/go-licenser go mod tidy
Rename GcsOptions to GCSOptions.
Fixed an issue in TCP and TLS outputs where the write buffer was being modified, which is unsafe. A new buffer is now used.
Resolved a potential context leak in the GCS output by ensuring the cancel function is always called.
andrewkroh
force-pushed
the
fix/linter-warnings
branch
from
57a65cf to
42c0f59
Compare
💚 Build Succeeded
History
|
andrewkroh
commented
Nov 7, 2025
|
|
||
| tool ( | ||
| github.com/elastic/go-licenser | ||
| github.com/golangci/golangci-lint/v2/cmd/golangci-lint |
Member
Author
There was a problem hiding this comment.
Looking back at this months later, I'm less satisfied with the go get -tool changes. If others were consuming this project as a library I would be much less inclined to use this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a large number of golangci-lint warnings across the codebase.
The fixes span multiple categories of linters.
io.Copyandflag.Value.Set.gofumpt.io/ioutilwithioandospackages.zap.OnFatalwithzap.WithFatalHook._).context.Contextas the first argument.internal/output/tlsandinternal/output/udppackages to match their dir names.The only remaining linter warning is for the TODO in the udp output.