Skip to content

Sale price display updates #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 21, 2025
Merged

Sale price display updates #380

merged 9 commits into from
Mar 21, 2025

Conversation

amcaffee-ep
Copy link
Collaborator

@amcaffee-ep amcaffee-ep commented Mar 18, 2025

Describe your changes

Issue ticket number and link

Checklist before requesting a review

Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 3b2b974

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
commerce-essentials ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 0:40am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
composable-frontend-algolia ⬜️ Ignored (Inspect) Mar 21, 2025 0:40am
composable-frontend-docs ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 0:40am
composable-frontend-simple ⬜️ Ignored (Inspect) Mar 21, 2025 0:40am

@vercel vercel bot temporarily deployed to Preview – commerce-essentials March 20, 2025 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – commerce-essentials March 20, 2025 15:06 Inactive
@vercel vercel bot temporarily deployed to Preview – commerce-essentials March 20, 2025 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – commerce-essentials March 20, 2025 18:04 Inactive
@vercel vercel bot temporarily deployed to Preview – commerce-essentials March 21, 2025 12:40 Inactive
@vercel vercel bot temporarily deployed to Preview – commerce-essentials March 21, 2025 12:41 Inactive
Copy link
Collaborator

@jimmy-ventura-elasticpath jimmy-ventura-elasticpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ts-ignore on the product component are not nice but getting the type of a nested object is painful and I don't know how to make it play nice with the compiler without investing some time so all good on my end ^_^

@amcaffee-ep amcaffee-ep merged commit a5476a4 into main Mar 21, 2025
7 checks passed
@amcaffee-ep amcaffee-ep deleted the feat/sale-price-display branch March 21, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants