Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres-pglite as submodule #461

Merged
merged 22 commits into from
Jan 16, 2025
Merged

Conversation

copiltembel
Copy link
Collaborator

This PR moves the postgres-pglite dependency out of this repo and adds it as a submodule. The postgres-pglite repo contains Postgres with pglite changes needed for this to work.

Tested with:

$ git clone --single-branch --branch=tudor/move-postgres-pglite-to-ext-repo --recurse-submodules https://github.com/electric-sql/pglite.git
$ cd pglite
$ pnpm install
$ pnpm build:all
$ cd packages/pglite/
& pnpm test

@copiltembel
Copy link
Collaborator Author

copiltembel commented Dec 9, 2024

Need to update the github actions.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

We still have the ./extra and ./patches dirs, should we move them too? Or we do that in another step.

@@ -12,7 +12,7 @@
"ci:publish": "pnpm changeset publish",
"build:all": "pnpm wasm:build && pnpm ts:build",
"ts:build": "pnpm -r --filter \"./packages/**\" build",
"wasm:build": "bash ./cibuild/build-with-docker.sh"
"wasm:build": "bash -c \"pushd postgres-pglite && ./pglite/cibuild/build-with-docker.sh && popd && cp -r postgres-pglite/pglite/dist ./packages/pglite/release \""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now, but in a future tidy up we need to make this work cross platform (i.e. windows).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is very ugly but gets the job done!

@copiltembel
Copy link
Collaborator Author

We still have the ./extra and ./patches dirs, should we move them too? Or we do that in another step.

Done, thanks!

@copiltembel copiltembel merged commit ac7622c into main Jan 16, 2025
7 checks passed
@copiltembel copiltembel deleted the tudor/move-postgres-pglite-to-ext-repo branch January 16, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants