Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add refreshArrayTypes() call to re-sync newly created complex array columns, like enums #500

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

fgodino-milu
Copy link
Contributor

Fixes #469

Introduces a new method refreshArrayTypes that allows to resync the internal array types to handle the serialization and parsing.

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fgodino-milu this is awesome!!

It's almost perfect, I think the only thing we need to add Is the refreshArrayTypes to the PGliteInterface interface as thats what defines the universal interface we would want to expose from any pglite implementation (we have the main PGlite and PGliteWorker at the moment, but are likely to have others in future)

If you are happy to add that we can get this merged 🥳

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @fgodino-milu 🥳

@samwillis samwillis merged commit d93c1bb into electric-sql:main Jan 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] this.serializers does not get updated when adding new array types
2 participants