Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to submodule #502

Closed
wants to merge 2 commits into from
Closed

Updates to submodule #502

wants to merge 2 commits into from

Conversation

copiltembel
Copy link
Collaborator

This is to bring the latest updates of the postgres-pglite repo in here.

@copiltembel copiltembel requested a review from samwillis January 16, 2025 13:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Built bundles:

@samwillis
Copy link
Collaborator

@copiltembel the final step of CI, building the site / demos, is failing. Not sure why.

pmp-p
pmp-p requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@pmp-p pmp-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep if ./cibuild/sdk.sh, the check must be on exit code , not output

@copiltembel
Copy link
Collaborator Author

keep if ./cibuild/sdk.sh, the check must be on exit code , not output

Thanks! I will abandon this PR as there are more up to date changes incoming soon.

@copiltembel copiltembel deleted the tudor/updateSubmodule branch January 20, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmp-p pmp-p pmp-p requested changes

@samwillis samwillis Awaiting requested review from samwillis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@copiltembel @samwillis @pmp-p