Skip to content

fix: resolve yamllint inline comment spacing in workflow files#40

Merged
electrocucaracha merged 2 commits intomasterfrom
copilot/fix-linting-issues
Mar 14, 2026
Merged

fix: resolve yamllint inline comment spacing in workflow files#40
electrocucaracha merged 2 commits intomasterfrom
copilot/fix-linting-issues

Conversation

Copy link
Contributor

Copilot AI commented Mar 14, 2026

yamllint's comments rule (inherited via extends: default in .yaml-lint.yml) requires at least 2 spaces before inline comments. All three workflow files violated this with single-space-prefixed version annotations on uses: lines.

Changes

  • .github/workflows/lint.yml, on_demand.yml, update.yml: Added the required second space before inline # version comments on uses: action pin lines.
# Before
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # 6.0.2

# After
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # 6.0.2

The fix aligns with the existing .yamlfmt config (pad_line_comments: 2), making it stable under make fmt — running yamlfmt -dstar **/*.{yaml,yml} after this change produces no diff.


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: electrocucaracha <2782150+electrocucaracha@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix all linting issues and verify with make lint fix: resolve yamllint inline comment spacing in workflow files Mar 14, 2026
Copilot AI requested a review from electrocucaracha March 14, 2026 22:25
@electrocucaracha electrocucaracha marked this pull request as ready for review March 14, 2026 22:28
@qodo-code-review
Copy link

Review Summary by Qodo

Fix yamllint inline comment spacing in workflow files

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Add required second space before inline YAML comments
• Align workflow files with yamllint comments rule
• Ensure stability under make fmt formatting
Diagram
flowchart LR
  A["Workflow files<br/>with single-space comments"] -- "Add second space<br/>before # comments" --> B["Compliant with<br/>yamllint rules"]
  B -- "Stable under<br/>make fmt" --> C["No formatting<br/>diffs produced"]
Loading

Grey Divider

File Changes

1. .github/workflows/lint.yml 🐞 Bug fix +5/-5

Fix inline comment spacing in lint workflow

• Added second space before inline version comments on 4 uses: lines
• Affected actions: actions/checkout, tcort/github-action-markdown-link-check,
 super-linter/super-linter
• Changes align with .yamlfmt config pad_line_comments: 2

.github/workflows/lint.yml


2. .github/workflows/on_demand.yml 🐞 Bug fix +3/-3

Fix inline comment spacing in on-demand workflow

• Added second space before inline version comments on 2 uses: lines
• Affected actions: actions/checkout, luizm/action-sh-checker
• Resolves yamllint comments rule violations

.github/workflows/on_demand.yml


3. .github/workflows/update.yml 🐞 Bug fix +2/-2

Fix inline comment spacing in update workflow

• Added second space before inline version comments on 2 uses: lines
• Affected actions: actions/checkout, technote-space/create-pr-action
• Ensures consistency with yamllint configuration

.github/workflows/update.yml


Grey Divider

Qodo Logo

@qodo-code-review
Copy link

qodo-code-review bot commented Mar 14, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@electrocucaracha electrocucaracha merged commit 02ee41f into master Mar 14, 2026
1 of 2 checks passed
@electrocucaracha electrocucaracha deleted the copilot/fix-linting-issues branch March 14, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants