fix: resolve yamllint inline comment spacing in workflow files#40
Merged
electrocucaracha merged 2 commits intomasterfrom Mar 14, 2026
Merged
fix: resolve yamllint inline comment spacing in workflow files#40electrocucaracha merged 2 commits intomasterfrom
electrocucaracha merged 2 commits intomasterfrom
Conversation
Co-authored-by: electrocucaracha <2782150+electrocucaracha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix all linting issues and verify with make lint
fix: resolve yamllint inline comment spacing in workflow files
Mar 14, 2026
Review Summary by QodoFix yamllint inline comment spacing in workflow files
WalkthroughsDescription• Add required second space before inline YAML comments • Align workflow files with yamllint comments rule • Ensure stability under make fmt formatting Diagramflowchart LR
A["Workflow files<br/>with single-space comments"] -- "Add second space<br/>before # comments" --> B["Compliant with<br/>yamllint rules"]
B -- "Stable under<br/>make fmt" --> C["No formatting<br/>diffs produced"]
File Changes1. .github/workflows/lint.yml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yamllint's
commentsrule (inherited viaextends: defaultin.yaml-lint.yml) requires at least 2 spaces before inline comments. All three workflow files violated this with single-space-prefixed version annotations onuses:lines.Changes
.github/workflows/lint.yml,on_demand.yml,update.yml: Added the required second space before inline#version comments onuses:action pin lines.The fix aligns with the existing
.yamlfmtconfig (pad_line_comments: 2), making it stable undermake fmt— runningyamlfmt -dstar **/*.{yaml,yml}after this change produces no diff.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.