fix: Only update AppArmor profile if not chroot'ed #8843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 190dbbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fiesh
force-pushed
the
do-not-update-apparmor-in-chroot
branch
2 times, most recently
from
85b87f5 to
4177f93
Compare
fiesh
changed the title
mmaietta
reviewed
Feb 5, 2025
fiesh
force-pushed
the
do-not-update-apparmor-in-chroot
branch
from
0bd8e7f to
38cb462
Compare
This prevents `postinst` script failure when run in a `chroot` environment. This closes electron-userland#8841.
fiesh
force-pushed
the
do-not-update-apparmor-in-chroot
branch
from
38cb462 to
2f13232
Compare
|
Ok, I'm not sure why https://github.com/electron-userland/electron-builder/actions/runs/13157636243/job/36726618639 fails. Is it trying to keep explicit executable paths out of the script? If so, should we better use |
|
@fiesh I gotchu covered, it just needs a snapshot update as the unit test verifies that the |
This was referenced Feb 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
postinstscript failure when run in achrootenvironment.This closes #8841.